Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2323] Unlist Market #349

Merged
merged 41 commits into from
Sep 5, 2024
Merged

[VEN-2323] Unlist Market #349

merged 41 commits into from
Sep 5, 2024

Conversation

web3rover
Copy link
Collaborator

Description

Resolves #

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@web3rover web3rover marked this pull request as ready for review January 22, 2024 13:21
@web3rover web3rover self-assigned this Jan 22, 2024
GitGuru7
GitGuru7 reviewed Jan 29, 2024
View reviewed changes
contracts/Comptroller.sol Outdated Show resolved Hide resolved
contracts/Comptroller.sol Outdated Show resolved Hide resolved
@chechu chechu added this to the 032 milestone Feb 9, 2024
0xlucian
0xlucian previously approved these changes Feb 20, 2024
View reviewed changes
Debugger022
Debugger022 previously approved these changes Feb 23, 2024
View reviewed changes
chechu
chechu reviewed Feb 23, 2024
View reviewed changes
contracts/Comptroller.sol Outdated Show resolved Hide resolved
@web3rover web3rover dismissed stale reviews from Debugger022 and 0xlucian via 6dacce2 March 4, 2024 14:46
@chechu chechu added the audit label Mar 6, 2024
web3rover and others added 15 commits March 29, 2024 18:42
@chechu chechu removed the audit label Aug 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 2, 2024

Code Coverage

Package Line Rate Branch Rate Health
contracts 94% 76% ✔
contracts.Gateway 98% 68% ✔
contracts.Gateway.Interfaces 100% 100% ✔
contracts.Lens 95% 71% ✔
contracts.Lens.legacy 0% 0% ❌
contracts.Pool 100% 92% ✔
contracts.Rewards 96% 70% ✔
contracts.Shortfall 100% 85% ✔
contracts.legacy.RiskFund 0% 0% ❌
contracts.lib 100% 89% ✔
Summary 76% (1557 / 2055) 65% (516 / 798) ➖

@web3rover web3rover merged commit 87907a8 into develop Sep 5, 2024
4 checks passed
@web3rover web3rover deleted the feat/unlist-market branch September 5, 2024 12:05
@chechu chechu mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitGuru7 GitGuru7 GitGuru7 left review comments

@Debugger022 Debugger022 Debugger022 left review comments

@chechu chechu chechu approved these changes

@0xlucian 0xlucian 0xlucian left review comments

@kkirka kkirka Awaiting requested review from kkirka

Assignees

@web3rover web3rover

Labels
None yet
Projects
None yet
Milestone
032
Development

Successfully merging this pull request may close these issues.
6 participants
@web3rover @chechu @0xlucian @Debugger022 @GitGuru7 @Narayanprusty